Subscribe cancel handle movement #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is especially useful when scrolling on the mobile device so that the slider value change is cancelled when the scroll is detected on arbitrary scrollable container component.
dolezaljan
force-pushed
the
cancel-handle-movement
branch
from
d38af6e to
b4acc46
Compare
…ct if no movement occured multiple sliders might be subscribed to the same cancel EventEmitter but typically only one actually needs to act upon the cancel event
example.webm |
…dentifier matches API docs keyword better (cancelHandleMovement -> cancelUserChange)
piotrdz
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Consider having a touch screen where one tries to do a scroll of a component containing ngx-slider. If the scroll touch gesture is started on the ngx-slider bar the value of the ngx-slider is changed to where the touch occurred. One might want the value not to be changed.
Solution
This allows parent component containing ngx-slider to issue an event informing the ngx-slider to basically not take an action upon this touch event. I.e. the parent decides whether touch event belongs to ngx-slider or not.
Limitations / Future work
The handle movement is started and after the cancel event it moves back to the original position. Some other solution that would prevent such a "glitch" completely could be nice.
Closes #139